Skip to content

feat: redesign error alert #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 7, 2022
Merged

feat: redesign error alert #4403

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7da8608
added a warning summary component
Kira-Pilot Oct 4, 2022
a15a59f
added warning to workspace page
Kira-Pilot Oct 4, 2022
59ceb62
consolidated warnings
Kira-Pilot Oct 5, 2022
5db509b
prettier
Kira-Pilot Oct 5, 2022
5aeb6e2
updated design
Kira-Pilot Oct 5, 2022
5c517d2
added color scheme
Kira-Pilot Oct 6, 2022
06b5fbd
updated expander component
Kira-Pilot Oct 6, 2022
44b2748
cleanup
Kira-Pilot Oct 6, 2022
7b5ef37
fixed tests
Kira-Pilot Oct 6, 2022
658ffe2
Merge remote-tracking branch 'origin/main' into error-message-redesig…
Kira-Pilot Oct 6, 2022
f0175da
fixed height issue
Kira-Pilot Oct 6, 2022
d115771
prettier
Kira-Pilot Oct 6, 2022
7da9dc6
use theme constants
Kira-Pilot Oct 6, 2022
f6356b3
increased icon margin
Kira-Pilot Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed tests
  • Loading branch information
@Kira-Pilot
Kira-Pilot committed Oct 6, 2022
commit 7b5ef378afbbab08a34659fd5f7db2f138ebb428
13 changes: 10 additions & 3 deletions site/src/components/ErrorSummary/ErrorSummary.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import { fireEvent, render, screen } from "@testing-library/react"
import { ErrorSummary } from "./ErrorSummary"
import { i18n } from "i18n"

const { t } = i18n

describe("ErrorSummary", () => {
it("renders", async () => {
Expand All @@ -26,7 +29,8 @@ describe("ErrorSummary", () => {
render(<ErrorSummary error={error} />)

// Then
fireEvent.click(screen.getByText("More"))
const expandText = t("ctas.expand", { ns: "common" })
fireEvent.click(screen.getByText(expandText))
const element = await screen.findByText(
"The resource you requested does not exist in the database.",
{ exact: false },
Expand All @@ -48,8 +52,11 @@ describe("ErrorSummary", () => {
render(<ErrorSummary error={error} />)

// Then
fireEvent.click(screen.getByText("More"))
fireEvent.click(screen.getByText("Less"))
const expandText = t("ctas.expand", { ns: "common" })
const collapseText = t("ctas.collapse", { ns: "common" })

fireEvent.click(screen.getByText(expandText))
fireEvent.click(screen.getByText(collapseText))
const element = await screen.findByText(
"The resource you requested does not exist in the database.",
{ exact: false },
Expand Down