Skip to content

chore: add ignoreRestSiblings to no-unused-vars ESLint rule #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2022
Merged

chore: add ignoreRestSiblings to no-unused-vars ESLint rule #4404

merged 2 commits into from
Oct 7, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Oct 6, 2022 •
edited
Loading

This PR adds a new setting to one of our ESLint rules called ignoreRestSiblings which will come in handy if we use the spread operator to pass an object and exclude specific properties.

  • chore: add ignoreRestSiblings to eslint config
  • fix(site): remove eslint warning in

@jsjoeio jsjoeio self-assigned this Oct 6, 2022
@jsjoeio jsjoeio changed the title jsjoeio/fix markdown chore: add ignoreRestSiblings to no-unused-vars ESLint rule Oct 6, 2022
@jsjoeio jsjoeio requested a review from BrunoQuaresma October 6, 2022 21:05
@jsjoeio jsjoeio marked this pull request as ready for review October 6, 2022 21:05
@jsjoeio jsjoeio requested a review from a team as a code owner October 6, 2022 21:05
BrunoQuaresma
BrunoQuaresma approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for adding this.

@jsjoeio jsjoeio merged commit 2b6586d into main Oct 7, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-markdown branch October 7, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @BrunoQuaresma