Skip to content

fix: Fix keyboard focus styles on buttons #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix #4262

@BrunoQuaresma BrunoQuaresma self-assigned this Oct 7, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner October 7, 2022 16:40
@BrunoQuaresma BrunoQuaresma requested review from presleyp and removed request for a team October 7, 2022 16:40
@@ -36,6 +36,10 @@ export const getOverrides = ({ palette, breakpoints }: Theme): Overrides => {
textTransform: "none",
letterSpacing: "none",
border: `1px solid ${palette.divider}`,

"&:focus-visible": {
outline: `2px solid ${palette.primary.dark}`,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the text input styles for focus

@BrunoQuaresma BrunoQuaresma merged commit 50966c4 into main Oct 7, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-outline branch October 7, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(UI): Tab selection does not work on delete workspace dialogue.
2 participants