feat: deployment flags #4426
Merged
feat: deployment flags #4426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
Oct 10, 2022
Kira-Pilot
reviewed
Oct 10, 2022
Kira-Pilot
approved these changes
Oct 10, 2022
deansheather
approved these changes
Oct 10, 2022
kylecarbs
added a commit
that referenced
this pull request
Oct 10, 2022
This reverts commit b1faaef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all of the flags used to configure
coder serverinto a centralized structcodersdk.DeploymentFlagsthat is now also returned by the api at/api/v2/flags/deployment. We scrub secret values out before returning them on the API and the endpoint currently only authorized the builtinownerrole.This satisfies the backend portion of #4203.
Future work
DeploymentFlagsfield for conditional logic