Skip to content

feat: add ingress to helm chart #4446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2022
Merged

feat: add ingress to helm chart #4446

merged 3 commits into from
Oct 10, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Oct 10, 2022 •
edited
Loading

Fixes #3959. Reverted from 761e124

  • Test it
  • Support multiple certifcates
  • Consider warning the user or automatically changing ServiceType to CluserIP if ingress is enabled (however v1 does not do this)

ericpaulsen
ericpaulsen approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@ericpaulsen ericpaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

deansheather
deansheather approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works with nginx ingress controller.

@deansheather deansheather marked this pull request as ready for review October 10, 2022 21:51
@deansheather
Copy link
Member

I don't think we should worry about warning, it wasn't a problem in v1 and it's easy to add later if we want to.

@bpmct bpmct enabled auto-merge (squash) October 10, 2022 21:53
@bpmct bpmct merged commit 5ca17c3 into main Oct 10, 2022
@bpmct bpmct deleted the helm-ingress branch October 10, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpaulsen ericpaulsen ericpaulsen approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@deansheather deansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm: support ingress configuration
3 participants
@bpmct @deansheather @ericpaulsen