Skip to content

fix: Check if the response body is nil before panicing #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

fix: Check if the response body is nil before panicing #4448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Check if the response body is nil before panicing 
If a WebSocket connection couldn't be established, a panic would occur.
  • Loading branch information
@kylecarbs
kylecarbs committed Oct 10, 2022
commit 5906c5384a73504bdde04e7f9b4e4d90133e1ec0
3 changes: 3 additions & 0 deletions codersdk/provisionerdaemons.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ func (c *Client) provisionerJobLogsAfter(ctx context.Context, path string, after
CompressionMode: websocket.CompressionDisabled,
})
if err != nil {
if res == nil {
return nil, nil, err
}
return nil, nil, readBodyAsError(res)
}
logs := make(chan ProvisionerJobLog)
Expand Down