Skip to content

refactor(site): remove eslint-disable in ResourceAvatar #4463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

refactor(site): remove eslint-disable in ResourceAvatar #4463

merged 1 commit into from
Oct 11, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Oct 10, 2022 •
edited
Loading

This simplifies it a bit and allow us to remove the eslint-disable.

@jsjoeio jsjoeio self-assigned this Oct 10, 2022
@jsjoeio jsjoeio requested a review from BrunoQuaresma October 10, 2022 21:45
BrunoQuaresma
BrunoQuaresma approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jsjoeio jsjoeio marked this pull request as ready for review October 11, 2022 01:22
@jsjoeio jsjoeio requested a review from a team as a code owner October 11, 2022 01:22
@jsjoeio jsjoeio merged commit 8047a3e into main Oct 11, 2022
@jsjoeio jsjoeio deleted the jsjoeio/refactor-resource-avatar branch October 11, 2022 01:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @BrunoQuaresma