Skip to content

fix: Display Everyone group in the autocomplete #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

fix: Display Everyone group in the autocomplete #4488

merged 1 commit into from
Oct 11, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix #4465

@BrunoQuaresma BrunoQuaresma requested a review from bpmct October 11, 2022 16:50
@BrunoQuaresma BrunoQuaresma self-assigned this Oct 11, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner October 11, 2022 16:50
@BrunoQuaresma BrunoQuaresma requested review from presleyp and removed request for a team October 11, 2022 16:50
bpmct
bpmct reviewed Oct 11, 2022
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2022-10-11.at.1.07.46.PM.mov

I confirmed this works as expected but will defer to @coder/frontend to review the code

@kylecarbs kylecarbs merged commit c619138 into main Oct 11, 2022
@kylecarbs kylecarbs deleted the bq/4465 branch October 11, 2022 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct left review comments

@kylecarbs kylecarbs kylecarbs approved these changes

@presleyp presleyp Awaiting requested review from presleyp presleyp was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groups: I can't add Everyone back
3 participants
@BrunoQuaresma @kylecarbs @bpmct