Skip to content

chore: change view perm to use #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 12, 2022
Merged

chore: change view perm to use #4496

merged 4 commits into from
Oct 12, 2022

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Oct 11, 2022 •
edited
Loading

image

this also updates the descriptions

fixes #4456

@sreya sreya requested a review from a team as a code owner October 11, 2022 20:13
@sreya sreya requested review from code-asher and removed request for a team October 11, 2022 20:13
@github-actions
Copy link

github-actions bot commented Oct 11, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sreya sreya requested review from ammario and a team October 11, 2022 20:14
@sreya
Copy link
Collaborator Author

sreya commented Oct 11, 2022

I have read the CLA Document and I hereby sign the CLA

@sreya sreya requested review from BrunoQuaresma and removed request for code-asher and a team October 11, 2022 20:17
ammario
ammario approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thank you for the "use" ;):):)

BrunoQuaresma
BrunoQuaresma approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sreya sreya merged commit 0fa8f52 into main Oct 12, 2022
@sreya sreya deleted the jon/viewuse branch October 12, 2022 19:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@ammario ammario ammario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groups: rename view permission to use
3 participants
@sreya @BrunoQuaresma @ammario