keep diffs with 0 changes

coder · Kira-Pilot · Oct 14, 2022 · Oct 12, 2022 · Oct 12, 2022 · Oct 12, 2022
commit e259eba0b78fa6324c8ff71e75a806ca73042c0c
diff --git a/coderd/audit/audit.go b/coderd/audit/audit.go
@@ -39,5 +39,5 @@ func (a *MockAuditor) Export(_ context.Context, alog database.AuditLog) error {
 }
 
 func (*MockAuditor) diff(any, any) Map {
-	return Map{"ttl": {"3600000000000", "7200000000000", false}}
+	return Map{}
 }
diff --git a/coderd/audit/request.go b/coderd/audit/request.go
@@ -115,10 +115,6 @@ func InitRequest[T Auditable](w http.ResponseWriter, p *RequestParams) (*Request
 		if sw.Status < 400 {
 			diff := Diff(p.Audit, req.Old, req.New)
 
-			if len(diff) == 0 {
-				return
-			}
-
 			var err error
 			diffRaw, err = json.Marshal(diff)
 			if err != nil {

diff --git a/site/src/pages/AuditPage/AuditPage.test.tsx b/site/src/pages/AuditPage/AuditPage.test.tsx
@@ -30,23 +30,6 @@ describe("AuditPage", () => {
     screen.getByTestId(`audit-log-row-${MockAuditLog2.id}`)
   })
 
-  it("filters out audit logs with empty diffs", async () => {
-    server.use(
-      rest.get(`/api/v2/audit`, (_, res, ctx) => {
-        return res(ctx.status(200), ctx.json(MockAuditLogWithEmptyDiff))
-      }),
-    )
-
-    // When
-    render(<AuditPage />)
-
-    // Then
-    const logRow = screen.queryByTestId(
-      `audit-log-row-${MockAuditLogWithEmptyDiff.id}`,
-    )
-    expect(logRow).not.toBeInTheDocument()
-  })
-
   describe("Filtering", () => {
     it("filters by typing", async () => {
       const getAuditLogsSpy = jest

diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -912,26 +912,6 @@ export const MockAuditLog2: TypesGen.AuditLog = {
   },
 }
 
-export const MockAuditLogWithEmptyDiff: TypesGen.AuditLog = {
-  id: "958d5bdc-d034-4857-891e-33393ba07e55",
-  request_id: "0585f890-2659-4761-bcb4-3bbca1fe4ab7",
-  time: "2022-10-12T13:36:31.682107Z",
-  organization_id: "fc0774ce-cc9e-48d4-80ae-88f7a4d4a8b0",
-  ip: "127.0.0.1",
-  user_agent:
-    '"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36"',
-  resource_type: "workspace",
-  resource_id: "ef8d1cf4-82de-4fd9-8980-047dad6d06b5",
-  resource_target: "bruno-dev",
-  resource_icon: "",
-  action: "create",
-  diff: {},
-  status_code: 200,
-  additional_fields: "",
-  description: "{user} updated workspace {target}",
-  user: MockUser,
-}
-
 export const MockWorkspaceQuota: TypesGen.WorkspaceQuota = {
   user_workspace_count: 0,
   user_workspace_limit: 100,

diff --git a/site/src/xServices/audit/auditXService.ts b/site/src/xServices/audit/auditXService.ts
@@ -131,12 +131,8 @@ export const auditMachine = createMachine(
           }).then((data) => data.count),
         ])
 
-        // Filter out any logs that don't have an actual diff to present to the user
-        const filteredLogs = auditLogs.filter(
-          (log) => Object.entries(log.diff).length > 0,
-        )
         return {
-          auditLogs: filteredLogs,
+          auditLogs,
           count,
         }
       },