Skip to content

feat: add pagination to getWorkspaces #4521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 13, 2022
Merged

feat: add pagination to getWorkspaces #4521

merged 9 commits into from
Oct 13, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Oct 12, 2022 •
edited
Loading

Backend for workspace page - part of #3907

@f0ssel f0ssel force-pushed the f0ssel/pagination branch from 9882073 to 26428df Compare October 12, 2022 21:00
@f0ssel f0ssel requested review from deansheather and Emyrk October 12, 2022 21:01
@f0ssel f0ssel requested review from a team and presleyp and removed request for Emyrk and deansheather October 12, 2022 21:34
deansheather
deansheather approved these changes Oct 12, 2022
View reviewed changes
Emyrk
Emyrk reviewed Oct 13, 2022
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to GetAuthorizedWorkspaces too?

Nice 👍

@f0ssel f0ssel merged commit 459ee4e into main Oct 13, 2022
@f0ssel f0ssel deleted the f0ssel/pagination branch October 13, 2022 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sreya sreya sreya left review comments

@Emyrk Emyrk Emyrk left review comments

@deansheather deansheather deansheather approved these changes

+1 more reviewer

@presleyp presleyp presleyp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@f0ssel @presleyp @sreya @Emyrk @deansheather