Skip to content

feat: add avatar urls to groups #4525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 17, 2022
Merged

feat: add avatar urls to groups #4525

merged 16 commits into from
Oct 17, 2022

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Oct 13, 2022 •
edited
Loading

fixes #4502

@BrunoQuaresma i haven't done any validation of the avatar url in the FE, wasn't exactly sure what that should entail.

groups page:

image

edit page:

image

create page:

image

templates page:

image

@sreya sreya requested a review from a team as a code owner October 13, 2022 00:00
@sreya sreya requested review from Kira-Pilot and BrunoQuaresma and removed request for a team and Kira-Pilot October 13, 2022 00:00
@sreya sreya requested a review from coadler October 13, 2022 00:38
@sreya sreya requested review from Kira-Pilot and removed request for BrunoQuaresma October 13, 2022 20:22
@Kira-Pilot
Copy link
Member

@sreya I'm not sure if this out of the scope of this ticket, but when testing locally, I don't see the avatar show up in the groups page.

Also, if I go to edit the group, it seems like the URL isn't persisted in the input:

Kapture 2022-10-13 at 17 25 00

Let me know if I'm missing something!

@Kira-Pilot
Copy link
Member

Your Chromatic snapshots have some text overflow. I left a comment in there; reach out if you need any help resolving it!

@sreya
Copy link
Collaborator Author

sreya commented Oct 13, 2022

@Kira-Pilot what are you using as your backend? This includes a migration that supports the avatar_url in the database so if you're running against dev.coder.com or something it's not going to work. I looked at the snapshots you talked about and I don't see the text overflow you're talking about...perhaps we can discuss this offline?

@sreya
Copy link
Collaborator Author

sreya commented Oct 14, 2022

I looked at the snapshots you talked about and I don't see the text overflow you're talking about...perhaps we can discuss this offline?

Nvm I figured it out

@Kira-Pilot
Copy link
Member

@sreya ahhh, that was the issue. Thanks for explaining.
Looking great now!

bpmct
bpmct reviewed Oct 17, 2022
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the same component as the icon picker for "template settings" to support emojis?

@sreya
Copy link
Collaborator Author

sreya commented Oct 17, 2022

@bpmct i'm fine for that to be the next iteration but i'd like to merge this as-is

@sreya sreya merged commit e0a14f6 into main Oct 17, 2022
@sreya sreya deleted the jon/groupavatars branch October 17, 2022 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct left review comments

@coadler coadler coadler approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groups: add avatar_url to groups
4 participants
@sreya @Kira-Pilot @coadler @bpmct