add: helm binary download cmd #4526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericpaulsen i'll make you a deal, i'll implement some CI to push our helm chart to cc @deansheather @kylecarbs any reservations with me pushing our v2 helm chart to our helm repo? |
|
@sreya now that's an offer I can't refuse |
What do you want to call the package? coderv2? |
|
I was thinking coder-oss
…On Wed, Oct 12, 2022 at 10:05 PM Dean Sheather ***@***.***> wrote:
any reservations with me pushing our v2 helm chart to our helm repo?
What do you want to call the package? coderv2?
—
Reply to this email directly, view it on GitHub
<#4526 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFBTBEMAWCRFI6YH4ASQMLWC536VANCNFSM6AAAAAARDYIH5Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I think it's kinda weird tbh to call it oss when it's the enterprise binary |
|
It's still oss... @kylecarbs @ammario what should we call the helm repo for v2? |
|
oss makes sense to me since it's consistent with our docs. |
bpmct
approved these changes
Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a command for downloading the helm binary.
customers are typically installing the helm chart via a VM or other remote client, and it isn't entirely intuitive as to how to do this from the GitHub releases page.