feat: add auditing for groups #4527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
approved these changes
Oct 19, 2022
| @@ -24,3 +24,22 @@ func (a *Actions) Scan(src interface{}) error { | |||
| func (a *Actions) Value() (driver.Value, error) { | |||
| return json.Marshal(a) | |||
| } | |||
|
|
|||
| // TemplateACL is a map of ids to permissions. | |||
| type TemplateACL map[string][]rbac.Action | |||
There was a problem hiding this comment.
Could this be a map[uuid.UUID][]rbac.Action?
There was a problem hiding this comment.
possibly but it involves a lot of code changes, i'll try it out in a separate pr
|
🥳 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TemplateACLtype by turning it into a driver and integrating it more directly intosqlc.create group:
update group:
delete group:
update template acl:
fixes #4503