Skip to content

feat: add doas support #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2022
Merged

feat: add doas support #4531

merged 4 commits into from
Oct 16, 2022

Conversation

unknowndevQwQ
Copy link
Contributor

@unknowndevQwQ unknowndevQwQ commented Oct 13, 2022

Some people may have some reason to drop sudo and switch to doas

Fix: #4530
Also: coder/code-server#5600

Some people may have some reason to drop sudo and switch to doas
@github-actions
Copy link

github-actions bot commented Oct 13, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@unknowndevQwQ
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Just because it is relatively cold :-(

Co-authored-by: Kyle Carberry <kyle@carberry.com>
@kylecarbs kylecarbs enabled auto-merge (squash) October 13, 2022 20:31
@ammario
Copy link
Member

ammario commented Oct 13, 2022

@unknowndevQwQ git apply this to pass CI.

diff --git a/.github/workflows/typos.toml b/.github/workflows/typos.toml
index 90b0ea1c..d10d53c9 100644
--- a/.github/workflows/typos.toml
+++ b/.github/workflows/typos.toml
@@ -5,6 +5,8 @@ IST = "IST"
 MacOS = "macOS"
 
 [default.extend-words]
+# do as sudo replacement
+doas=doas
 
 [files]
 extend-exclude = [

auto-merge was automatically disabled October 14, 2022 00:50

Head branch was pushed to by a user without write access

@bpmct bpmct enabled auto-merge (squash) October 16, 2022 02:09
@bpmct bpmct merged commit efdd5d5 into coder:main Oct 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2022
@unknowndevQwQ unknowndevQwQ deleted the patch-2 branch October 16, 2022 08:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat Req: add doas support
4 participants