Skip to content

refactor: clean up api/error.ts #4542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2022
Merged

refactor: clean up api/error.ts #4542

merged 1 commit into from
Oct 14, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Oct 13, 2022

This removes an eslint-disable lint and updates the err type to
unknown instead of any which is more correct.

@jsjoeio
refactor: clean up api/error.ts
5a4609d 
This removes an eslint-disable lint and updates the `err` type to
`unknown` instead of `any` which is more correct.
@github-actions
Copy link

github-actions bot commented Oct 13, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jsjoeio jsjoeio self-assigned this Oct 13, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Oct 13, 2022

I have read the CLA Document and I hereby sign the CLA

@jsjoeio jsjoeio marked this pull request as ready for review October 13, 2022 21:02
@jsjoeio jsjoeio requested a review from a team as a code owner October 13, 2022 21:02
@jsjoeio jsjoeio requested review from BrunoQuaresma and removed request for a team October 13, 2022 21:02
@jsjoeio jsjoeio enabled auto-merge (squash) October 13, 2022 21:37
BrunoQuaresma
BrunoQuaresma approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsjoeio jsjoeio merged commit b140983 into main Oct 14, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-errors branch October 14, 2022 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @BrunoQuaresma