Skip to content

Show template average build #4545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Show template average build #4545

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4f33078
Compute template average build time
iskhakovt Sep 11, 2022
d0abdbe
Improve sql query & add front end
iskhakovt Sep 11, 2022
5bac9fc
sql style
iskhakovt Sep 11, 2022
151a76b
Simplify sql query
iskhakovt Sep 12, 2022
96b358f
Use humanised duration
iskhakovt Sep 12, 2022
94efda5
Merge branch 'main' into ti/template-build-avg-time
ammario Oct 13, 2022
5c4227a
Write and test metricscache
ammario Oct 14, 2022
0f5f07b
Complete tests
ammario Oct 14, 2022
4cc4a45
Merge remote-tracking branch 'origin/main' into ti/template-build-avg…
ammario Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into ti/template-build-avg-time
  • Loading branch information
@ammario
ammario committed Oct 13, 2022
commit 94efda50425c09cbb63e1876ec191e02bc5dad25
118 changes: 28 additions & 90 deletions site/src/pages/TemplatesPage/TemplatesPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ import {

export const Language = {
buildTime: (buildTimeSec: number): string =>
buildTimeSec === -1 ? "Unknown" : dayjs.duration(buildTimeSec, "seconds").humanize(),
buildTimeSec === -1
? "Unknown"
: dayjs.duration(buildTimeSec, "seconds").humanize(),
developerCount: (activeCount: number): string => {
return `${formatTemplateActiveDevelopers(activeCount)} developer${
activeCount !== 1 ? "s" : ""
Expand Down Expand Up @@ -139,95 +141,31 @@ export const TemplatesPageView: FC<
</Maybe>
</PageHeader>

<TableContainer>
<Table>
<TableHead>
<TableRow>
<TableCell width="39%">{Language.nameLabel}</TableCell>
<TableCell width="15%">{Language.buildTimeLabel}</TableCell>
<TableCell width="15%">{Language.usedByLabel}</TableCell>
<TableCell width="15%">{Language.lastUpdatedLabel}</TableCell>
<TableCell width="15%">{Language.createdByLabel}</TableCell>
<TableCell width="1%"></TableCell>
</TableRow>
</TableHead>
<TableBody>
{props.loading && <TableLoader />}
{!props.loading && !props.templates?.length && (
<TableRow>
<TableCell colSpan={999}>
<EmptyState
message={Language.emptyMessage}
description={
props.canCreateTemplate
? Language.emptyDescription
: Language.emptyViewNoPerms
}
descriptionClassName={styles.emptyDescription}
cta={<CodeExample code="coder templates init" />}
/>
</TableCell>
</TableRow>
)}
{props.templates?.map((template) => {
const templatePageLink = `/templates/${template.name}`
const hasIcon = template.icon && template.icon !== ""

return (
<TableRow
key={template.id}
hover
data-testid={`template-${template.id}`}
tabIndex={0}
onKeyDown={(event) => {
if (event.key === "Enter") {
navigate(templatePageLink)
}
}}
className={styles.clickableTableRow}
>
<TableCellLink to={templatePageLink}>
<AvatarData
title={template.name}
subtitle={template.description}
highlightTitle
avatar={
hasIcon ? (
<div className={styles.templateIconWrapper}>
<img alt="" src={template.icon} />
</div>
) : undefined
}
/>
</TableCellLink>

<TableCellLink to={templatePageLink}>
<span style={{ color: theme.palette.text.secondary }}>
{Language.buildTime(template.average_build_time_sec)}
</span>
</TableCellLink>

<TableCellLink to={templatePageLink}>
<span style={{ color: theme.palette.text.secondary }}>
{Language.developerCount(template.active_user_count)}
</span>
</TableCellLink>

<TableCellLink data-chromatic="ignore" to={templatePageLink}>
<span style={{ color: theme.palette.text.secondary }}>
{createDayString(template.updated_at)}
</span>
</TableCellLink>
<TableCellLink to={templatePageLink}>
<span style={{ color: theme.palette.text.secondary }}>
{template.created_by_name}
</span>
</TableCellLink>
<TableCellLink to={templatePageLink}>
<div className={styles.arrowCell}>
<KeyboardArrowRight className={styles.arrowRight} />
</div>
</TableCellLink>
<ChooseOne>
<Cond condition={Boolean(props.getOrganizationsError)}>
<AlertBanner
severity="error"
error={props.getOrganizationsError}
text={t("errors.getOrganizationsError")}
/>
</Cond>
<Cond condition={Boolean(props.getTemplatesError)}>
<AlertBanner
severity="error"
error={props.getTemplatesError}
text={t("errors.getTemplatesError")}
/>
</Cond>
<Cond>
<TableContainer>
<Table>
<TableHead>
<TableRow>
<TableCell width="50%">{Language.nameLabel}</TableCell>
<TableCell width="16%">{Language.usedByLabel}</TableCell>
<TableCell width="16%">{Language.lastUpdatedLabel}</TableCell>
<TableCell width="16%">{Language.createdByLabel}</TableCell>
<TableCell width="1%"></TableCell>
</TableRow>
</TableHead>
<TableBody>
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.