Skip to content

fix: Fix template create with sub-folders on Windows #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

mafredri
Copy link
Member

On Windows, files in tar archives were stored with Windows
path-separators resulting in them being individual files as opposed to
contained in a folder.

This commit ensures Unix-based paths (slash) are being used inside tar
archives.

Exmple of previous output:

/tmp/provisionerd673501182/images:
/tmp/provisionerd673501182/:
README.md
images
images\base.Dockerfile
images\java.Dockerfile
images\node.Dockerfile
main.tf

Fixes #2815

On Windows, files in tar archives were stored with Windows
path-separators resulting in them being individual files as opposed to
contained in a folder.

This commit ensures Unix-based paths (slash) are being used inside tar
archives.

Exmple of previous output:

```
/tmp/provisionerd673501182/images:
/tmp/provisionerd673501182/:
README.md
images
images\base.Dockerfile
images\java.Dockerfile
images\node.Dockerfile
main.tf
```

Fixes #2815
@mafredri mafredri self-assigned this Oct 14, 2022
@mafredri mafredri requested a review from a team October 14, 2022 09:11
@github-actions
Copy link

github-actions bot commented Oct 14, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mafredri
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

@mafredri mafredri merged commit 19d7281 into main Oct 14, 2022
@mafredri mafredri deleted the mafredri/fix-template-create-on-windows branch October 14, 2022 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coder templates create using the template docker-image-builds and derivatives fails to build
2 participants