Skip to content

Add template build time stats #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 15, 2022
Merged

Add template build time stats #4557

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ab9fa00
Add template build time stats
ammario Oct 14, 2022
c96b9a3
Wire up frontend
ammario Oct 14, 2022
a8b81d5
Progress bar!
ammario Oct 14, 2022
304b072
Fix tests
ammario Oct 14, 2022
cbd778e
fixup! Fix tests
ammario Oct 15, 2022
9a339bd
fixup! Fix tests
ammario Oct 15, 2022
6c7d5fc
Fix DB null handling
ammario Oct 15, 2022
ab58545
fixup! Fix DB null handling
ammario Oct 15, 2022
dc19134
Job -> Build
ammario Oct 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Fix DB null handling
  • Loading branch information
@ammario
ammario committed Oct 15, 2022
commit ab585455000c283c8a5c735d294dbf546da43ff2
4 changes: 2 additions & 2 deletions coderd/metricscache/metricscache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func (c *Cache) refresh(ctx context.Context) error {
}
templateDAUs[template.ID] = convertDAUResponse(rows)
templateUniqueUsers[template.ID] = countUniqueUsers(rows)
avgBuildTime, err := c.database.GetTemplateAverageBuildTime(ctx, database.GetTemplateAverageBuildTimeParams{
templateAvgBuildTime, err := c.database.GetTemplateAverageBuildTime(ctx, database.GetTemplateAverageBuildTimeParams{
TemplateID: uuid.NullUUID{
UUID: template.ID,
Valid: true,
Expand All @@ -154,7 +154,7 @@ func (c *Cache) refresh(ctx context.Context) error {
if err != nil {
return err
}
templateAverageBuildTimeSec[template.ID] = time.Duration(float64(time.Second) * avgBuildTime)
templateAverageBuildTimeSec[template.ID] = time.Duration(float64(time.Second) * templateAvgBuildTime)
}
c.templateDAUResponses.Store(&templateDAUs)
c.templateUniqueUsers.Store(&templateUniqueUsers)
Expand Down