-
Notifications
You must be signed in to change notification settings - Fork 904
feat: add slug property to app, use in URLs #4573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE: great work!
coadler
approved these changes
Oct 18, 2022
kylecarbs
reviewed
Oct 18, 2022
coadler
approved these changes
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4571, Closes #4674
Adds
slug
property toworkspace_apps
in the database, which is copied from the new required terraformslug
property in templates. This new slug property is the only property accepted in application URLs including proxy path URLs. Existing bookmarks or tabs will need to be recreated from the dashboard to get new URLs in most cases (unless the app'sdisplay_name
field matches theslug
field).The app "display_name" field is still used for the button in the dashboard.
coder_app
resource names must match the regexprovisioner.ValidAppNameRegex
:Which is essentially:
TODO: