Skip to content

Support delete & stop transitions in build progress bar #4575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 17, 2022
Merged

Support delete & stop transitions in build progress bar #4575

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0ba618d
Support `delete` & `stop` in build progress bar
ammario Oct 16, 2022
40769bd
Use null types instead of -1 for simplicity
ammario Oct 16, 2022
61941ed
Fix pgcrypto bug in migration 59
ammario Oct 16, 2022
8d92c22
fixup! Fix pgcrypto bug in migration 59
ammario Oct 16, 2022
0263b09
Fix test bugs
ammario Oct 16, 2022
30fee3f
Update frontend
ammario Oct 16, 2022
4957b13
Add stories
ammario Oct 16, 2022
de58d53
fmt
ammario Oct 16, 2022
6b21f00
Remove visual stutter
ammario Oct 16, 2022
75b32c0
Comment
ammario Oct 16, 2022
c4181bc
Fix linting issue
ammario Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Comment
  • Loading branch information
@ammario
ammario committed Oct 16, 2022
commit 75b32c043c124fe10426e69c4ac59f8b1fb78040
16 changes: 11 additions & 5 deletions site/src/components/WorkspaceBuildProgress/WorkspaceBuildProgress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ const estimateFinish = (
const realPercentage = dayjs().diff(startedAt) / templateAverage

// Showing a full bar is frustrating.
if (realPercentage > 0.95) {
return [0.95, "Any moment now..."]
const maxPercentage = 0.99
if (realPercentage > maxPercentage) {
return [maxPercentage, "Any moment now..."]
}

return [
Expand Down Expand Up @@ -61,22 +62,27 @@ export const WorkspaceBuildProgress: FC<WorkspaceBuildProgressProps> = ({
buildEstimate,
}) => {
const styles = useStyles()

const job = workspace.latest_build.job

const [progressValue, setProgressValue] = useState(0)

// By default workspace is updated every second, which can cause visual stutter
// when the build estimate is a few seconds. The timer ensures no observable
// stutter in all cases.
useEffect(() => {
const updateProgress = () => {
if (job.status !== "running") {
setProgressValue(0)
return
}
setProgressValue(
estimateFinish(dayjs(job.started_at), buildEstimate)[0] * 100,
)
}
setTimeout(updateProgress, 100)
}, [progressValue, job.started_at, buildEstimate])
}, [progressValue, job, buildEstimate])

// buildEstimate may be undefined if the template is new or coderd hasn't
// finished initial metrics collection.
if (buildEstimate === undefined) {
return (
<div className={styles.stack}>
Expand Down