Skip to content

site: cleanup code in WorkspaceBuildProgress #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2022
Merged

site: cleanup code in WorkspaceBuildProgress #4584

merged 3 commits into from
Oct 17, 2022

Conversation

ammario
Copy link
Member

@ammario ammario commented Oct 17, 2022

No description provided.

@ammario ammario requested a review from a team as a code owner October 17, 2022 14:16
@ammario ammario requested review from Kira-Pilot and removed request for a team October 17, 2022 14:16
@ammario ammario changed the title site: cleanup code around WorkspaceBuildProgress site: cleanup code in WorkspaceBuildProgress Oct 17, 2022
@ammario ammario enabled auto-merge (squash) October 17, 2022 17:55
@ammario ammario requested review from BrunoQuaresma and removed request for Kira-Pilot October 17, 2022 18:53
BrunoQuaresma
BrunoQuaresma approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ammario ammario merged commit 8acba0c into main Oct 17, 2022
@ammario ammario deleted the pb-touchups branch October 17, 2022 19:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammario @BrunoQuaresma