Skip to content

feat: Add deployment settings page #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 17, 2022
Merged

feat: Add deployment settings page #4590

merged 17 commits into from
Oct 17, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Oct 17, 2022 •
edited
Loading

This allows deployment admins to view their deployment-level settings.

image

Try it yourself (it won't work for a few pages, because some types changed):

$ cd site
$ export CODER_HOST=https://dev.coder.com
$ yarn dev

@kylecarbs kylecarbs requested a review from a team as a code owner October 17, 2022 16:35
@kylecarbs kylecarbs self-assigned this Oct 17, 2022
@kylecarbs kylecarbs requested review from code-asher and removed request for a team October 17, 2022 16:35
@kylecarbs
feat: Add deployment settings page
c064adb 
This allows deployment admins to view options
set on their deployments.
BrunoQuaresma
BrunoQuaresma approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since this page does not execute any action. I'm ok to merge it without tests. But, I would add a simple storybook for it (I can do it right after you get this merged).

@kylecarbs
Copy link
Member Author

I'll let you add the Storybook. I'm sure there are a few style tweaks you may want to make now that it's filled out ;)

@kylecarbs kylecarbs merged commit 6b1b3a2 into main Oct 17, 2022
@kylecarbs kylecarbs deleted the deployment branch October 17, 2022 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@code-asher code-asher Awaiting requested review from code-asher code-asher was automatically assigned from coder/ts

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @BrunoQuaresma