Skip to content

fix: Add timeout to selecting a dev tunnel #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

fix: Add timeout to selecting a dev tunnel #4592

merged 1 commit into from
Oct 17, 2022

Conversation

kylecarbs
Copy link
Member

For some reason this timed out for a prospect. Even if this doesn't fix it, the problem will be revealed.

@kylecarbs kylecarbs requested a review from coadler October 17, 2022 17:44
@kylecarbs kylecarbs self-assigned this Oct 17, 2022
coadler
coadler approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@coadler coadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd do 5s to be safe tbh

@kylecarbs
fix: Add timeout to selecting a dev tunnel
291bfdf 
For some reason this timed out for a prospect. Even if this
doesn't fix it, the problem will be revealed.
@kylecarbs
Copy link
Member Author

@coadler done

@kylecarbs kylecarbs enabled auto-merge (squash) October 17, 2022 17:51
@kylecarbs kylecarbs mentioned this pull request Oct 17, 2022
Closed
@kylecarbs kylecarbs merged commit 5325bec into main Oct 17, 2022
@kylecarbs kylecarbs deleted the tunneltimeout branch October 17, 2022 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler