Skip to content

helm: add certs secret mount #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 7, 2022
Merged

helm: add certs secret mount #4641

merged 15 commits into from
Dec 7, 2022

Conversation

ericpaulsen
Copy link
Member

@ericpaulsen ericpaulsen commented Oct 19, 2022 •
edited
Loading

adds a volume & corresponding mount for CA certificates. a prospective customer needed this today when configuring their air-gapped deploy.

closes #4639

@ericpaulsen ericpaulsen self-assigned this Oct 19, 2022
deansheather
deansheather reviewed Oct 19, 2022
View reviewed changes
@ericpaulsen
Copy link
Member Author

ericpaulsen commented Oct 19, 2022 •
edited
Loading

@deansheather i updated it to use a list of secrets, using range to loop through the list. only question is, do we need a key value for the secret to reference in the mountPath?.

@deansheather
Copy link
Member

@ericpaulsen Yes, it will have to be a list of objects with the name and key field.

@deansheather
Copy link
Member

I think

deansheather
deansheather approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once tested LGTM but since I contributed you should get a second opinion :D

@ericpaulsen
Copy link
Member Author

@deansheather I tested with helm template. Looks good!

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 1, 2022
@github-actions github-actions bot closed this Nov 5, 2022
@bpmct bpmct reopened this Nov 14, 2022
@bpmct bpmct requested review from coadler and removed request for mafredri, kylecarbs, f0ssel and bpmct November 14, 2022 19:19
@github-actions github-actions bot removed the stale This issue is like stale bread. label Nov 15, 2022
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 22, 2022
@github-actions github-actions bot removed the stale This issue is like stale bread. label Nov 24, 2022
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 7, 2022
@ericpaulsen ericpaulsen merged commit fd54512 into main Dec 7, 2022
@ericpaulsen ericpaulsen deleted the helm-ca-certs branch December 7, 2022 23:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@ericpaulsen ericpaulsen

Labels
stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm: support mounting CA certs into coder pod via Helm
4 participants
@ericpaulsen @deansheather @coadler @bpmct