Skip to content

chore: Add generics to typescript generator #4658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

chore: Add generics to typescript generator #4658

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
02aa9ce
feat: Support generating generics in interfaces
Emyrk Oct 19, 2022
0e36824
Switch struct to a template
Emyrk Oct 19, 2022
f955150
Support generics in apitypings
Emyrk Oct 19, 2022
247bb1e
Ignore generics already declared
Emyrk Oct 19, 2022
481e498
Do not add ? to export type
Emyrk Oct 19, 2022
b22e365
Remove duplicate types
Emyrk Oct 19, 2022
3d64e13
Add generic support to instantiating generics
Emyrk Oct 20, 2022
6ea9164
fix: Add better generic bubbling up support
Emyrk Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not add ? to export type
  • Loading branch information
@Emyrk
Emyrk committed Oct 19, 2022
commit 481e498e6c6a783f8bbd5258d59fe10317d0c2a9
5 changes: 2 additions & 3 deletions scripts/apitypings/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,12 +312,11 @@ func (g *Generator) buildUnion(obj types.Object, st *types.Union) (string, error
optional = optional || scriptType.Optional
}

qMark := ""
if optional {
qMark = "?"
allTypes = append(allTypes, "null")
}

s.WriteString(fmt.Sprintf("export type %s%s = %s\n", obj.Name(), qMark, strings.Join(allTypes, " | ")))
s.WriteString(fmt.Sprintf("export type %s = %s\n", obj.Name(), strings.Join(allTypes, " | ")))

return s.String(), nil
}
Expand Down