Skip to content

feat: Add Git auth for GitHub, GitLab, Azure DevOps, and BitBucket #4670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 25, 2022
Merged

feat: Add Git auth for GitHub, GitLab, Azure DevOps, and BitBucket #4670

merged 22 commits into from
Oct 25, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Oct 20, 2022 •
edited
Loading

  • Pretty up the frontend landing page!
  • Add an error banner if multiple Git providers are configured but an Enterprise license doesn't allow it.
  • Add a ConfigMap for the new server.yaml.
  • Create tests for gitaskpass.go in cli/.
  • Make the PostgreSQL listener also poll for new secrets to prevent a race from occurring.
  • Document the nit about authenticating with VS Code Remote and adjusting the configuration location.

image

@kylecarbs kylecarbs requested a review from sreya October 20, 2022 18:13
@kylecarbs kylecarbs self-assigned this Oct 20, 2022
@kylecarbs kylecarbs mentioned this pull request Oct 21, 2022
Closed
bpmct
bpmct reviewed Oct 21, 2022
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylecarbs can you put this under CODER_EXPERIMENTAL?

@kylecarbs kylecarbs marked this pull request as ready for review October 24, 2022 20:08
@kylecarbs kylecarbs requested a review from a team as a code owner October 24, 2022 20:08
@kylecarbs kylecarbs requested review from code-asher and removed request for a team October 24, 2022 20:08
sreya
sreya approved these changes Oct 24, 2022
View reviewed changes
@kylecarbs kylecarbs force-pushed the gitprovider branch 4 times, most recently from b695c19 to 318234d Compare October 24, 2022 23:53
@kylecarbs kylecarbs force-pushed the gitprovider branch 2 times, most recently from 7d4252b to e462a13 Compare October 25, 2022 00:24
@kylecarbs kylecarbs merged commit eec406b into main Oct 25, 2022
@kylecarbs kylecarbs deleted the gitprovider branch October 25, 2022 00:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct left review comments

@sreya sreya sreya approved these changes

@code-asher code-asher Awaiting requested review from code-asher code-asher was automatically assigned from coder/ts

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @sreya @bpmct