Skip to content

helm: fix coder resource ref #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

helm: fix coder resource ref #4681

merged 1 commit into from
Oct 21, 2022

Conversation

ericpaulsen
Copy link
Member

@ericpaulsen ericpaulsen commented Oct 21, 2022 •
edited
Loading

fixes an incorrect reference to the coder.resource values in the coder.yaml template. this resulted in resource values not getting applied to the pod spec.

tested with helm template

@ericpaulsen ericpaulsen self-assigned this Oct 21, 2022
@ericpaulsen ericpaulsen changed the title fix: coder resource template fix: coder resource ref Oct 21, 2022
@ericpaulsen ericpaulsen changed the title fix: coder resource ref helm: fix coder resource ref Oct 21, 2022
@bpmct bpmct merged commit 72288c3 into main Oct 21, 2022
@bpmct bpmct deleted the helm-resource-bug branch October 21, 2022 15:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct approved these changes

@deansheather deansheather Awaiting requested review from deansheather

Assignees

@ericpaulsen ericpaulsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericpaulsen @bpmct