Skip to content

feat: Support x-forwarded-for headers for IPs #4684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into realip
  • Loading branch information
kylecarbs committed Oct 23, 2022
commit a8976d7b172d1cd577cfb3a128b4fb5785bf13ec
3 changes: 1 addition & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ LABEL \
org.opencontainers.image.description="A tool for provisioning self-hosted development environments with Terraform." \
org.opencontainers.image.url="https://github.com/coder/coder" \
org.opencontainers.image.source="https://github.com/coder/coder" \
org.opencontainers.image.version="$CODER_VERSION" \
org.opencontainers.image.licenses="AGPL-3.0"
org.opencontainers.image.version="$CODER_VERSION"

# The coder binary is injected by scripts/build_docker.sh.
COPY --chown=coder:coder --chmod=755 coder /opt/coder
Expand Down
2 changes: 1 addition & 1 deletion cli/cliui/provisionerjob.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func ProvisionerJob(ctx context.Context, writer io.Writer, opts ProvisionerJobOp

logs, closer, err := opts.Logs()
if err != nil {
return xerrors.Errorf("logs: %w", err)
return xerrors.Errorf("begin streaming logs: %w", err)
}
defer closer.Close()

Expand Down
8 changes: 8 additions & 0 deletions cli/config/file.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ import (
"path/filepath"
)

const (
FlagName = "global-config"
)

// Root represents the configuration directory.
type Root string

Expand Down Expand Up @@ -42,6 +46,10 @@ func (r Root) PostgresPort() File {
return File(filepath.Join(r.PostgresPath(), "port"))
}

func (r Root) DeploymentConfigPath() string {
return filepath.Join(string(r), "server.yaml")
}

// File provides convenience methods for interacting with *os.File.
type File string

Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.