-
Notifications
You must be signed in to change notification settings - Fork 875
feat: Add emoji picker to group settings #4685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"--rgb-background": theme.palette.background.paper, | ||
"--rgb-input": colors.gray[17], | ||
"--rgb-color": colors.gray[4], | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add this site/src/theme/overrides.ts
? I feel like I might not look for it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied this from the template settings one, but I assume we'll abstract this (maybe once it's used once more?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be wrong, but I thought the @global
key meant any classes defined within would be defined globally. So, if this is already declared in template settings, I'm surprised we need it here, too.
I'm suggesting we move it to overrides
because we have a bunch of other globals there, and it's nice to have them colocated. But not a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the @global
will go away when the component is unmounted, so it won't actually apply globally to all pages, just to the global scope on this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh, interesting; thanks for explaining. Alrighty, let's keep it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Fixes #4413.