feat: Redesign build logs #4734
Conversation
|
@kylecarbs the build table already has stories. But let me check how good is its coverage. |
| spacing={1} | ||
| > | ||
| <span> | ||
| <strong>{initiatedBy}</strong>{" "} |
There was a problem hiding this comment.
We can add translations with formatting by using a Trans component.
Presley asked me to write out an example, so there's one in our how-tos.
There was a problem hiding this comment.
I found it hard to use Trans here because of the conditionals but I moved the text to translation files.
| <TableRow | ||
| hover | ||
| data-testid={`build-${build.id}`} | ||
| className={styles.buildRow} |
There was a problem hiding this comment.
This is such a nice, tabbable table! I would love to be able to hit 'enter' and navigate to the log page without having to touch my mouse.
There was a problem hiding this comment.
I was watching TV when I "remembered" that I forgot to add the link 😆 I'm glad you found it as well, really good review 🌮
|
I cannot actually click into the logs anymore. Is this by design? If we've decided not to show the logs anymore, can we remove the pointer and table highlight on mouseover? |
Co-authored-by: Kira Pilot <kira@coder.com>
Co-authored-by: Kira Pilot <kira@coder.com>
Before:
After:
