chore: clean up eslint-disable lines #4735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsjoeio
commented
Oct 24, 2022
- chore: drop eslint-disable rule
- refactor: add types for makeMockApiError
jsjoeio
commented
Oct 24, 2022
| @@ -99,7 +99,6 @@ export interface WorkspaceScheduleFormValues { | |||
| ttl: number | |||
| } | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types | |||
There was a problem hiding this comment.
Removed it and ESLint was still happy 🤷🏼♂️ maybe it couldn't infer the type and now it can
| @@ -814,15 +814,29 @@ export const MockCancellationMessage = { | |||
| message: "Job successfully canceled", | |||
| } | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types | |||
There was a problem hiding this comment.
Previously, ESLint was unable because we weren't defining the return type.
I decided to break it out into three type aliases: input, output and the function. Makes it a bit more readable too 👍🏼
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.