refactor: clean up types in DAUChart #4737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up some types in `DAUChart.tsx`. Previously, we were type-casting which can lead to errors in production.
jsjoeio
commented
Oct 24, 2022
| @@ -71,7 +71,7 @@ export const DAUChart: FC<DAUChartProps> = ({ | |||
| defaults.font.family = theme.typography.fontFamily as string | |||
| defaults.color = theme.palette.text.secondary | |||
|
|
|||
| const options = { | |||
| const options: ChartOptions<'line'> = { | |||
There was a problem hiding this comment.
Suggested by docs to infer the correct options
| @@ -119,16 +119,13 @@ export const DAUChart: FC<DAUChartProps> = ({ | |||
| { | |||
| label: "Daily Active Users", | |||
| data: data, | |||
| lineTension: 1 / 4, | |||
| tension: 1 / 4, | |||
There was a problem hiding this comment.
Unsure if typo or API change but this matches the types and what you see in Chart.js docs
ammario
approved these changes
Oct 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some types in
DAUChart.tsx. Previously, we weretype-casting which can lead to errors in production.