feat: add workspace build start/stop to audit log #4744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
reviewed
Oct 25, 2022
| if alog.ResourceType == database.ResourceTypeWorkspaceBuild { | ||
| workspaceBytes := []byte(alog.AdditionalFields) | ||
| var workspaceResourceInfo WorkspaceResourceInfo | ||
| _ = json.Unmarshal(workspaceBytes, &workspaceResourceInfo) |
There was a problem hiding this comment.
Would this error be worth surfacing (even just through the logger) or is it expected that this might sometimes not contain workspace info?
| @@ -278,28 +278,59 @@ func (api *API) postWorkspaceBuilds(rw http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| // we only want to create audit logs for delete builds right now | |||
| auditor := api.Auditor.Load() | |||
There was a problem hiding this comment.
Not really related to your PR since this was already here so feel free to ignore but I wonder if the auditor should be set up before the authorization check so we can log unauthorized request attempts.
There was a problem hiding this comment.
Good eye! We have a separate ticket for this!
coderd/workspacebuilds.go
Outdated
| "workspaceName": workspace.Name, | ||
| } | ||
|
|
||
| wriBytes, _ := json.Marshal(workspaceResourceInfo) |
There was a problem hiding this comment.
Seems impossible for this to error but swallowed errors make me anxious 😨 Should we log it just in case?
code-asher
approved these changes
Oct 25, 2022
|
@code-asher thanks! I have a follow-up PR with that bold fix :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4625
This PR replaces #4636 which had a duplicate migration.
