fix: Remove pkg/sftp fork, fix SFTP test #4759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pkg/sftp#528 was merged, we can now remove the fork in favor of HEAD~1.
Note that sftp HEAD updated crypto packages, which causes conflict with tailscale, hence we update this to HEAD~1.
This also fixes a bug in our SFTP test where we were passing non-unix paths to
client.Createon Windows, (e.g.C:\User\...). This is not acceptable input (as I learned in my PR from sftp authors ❤️).