Skip to content

refactor: Refactor template resources #4789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 27, 2022
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Oct 27, 2022

Before:
Screen Shot 2022-10-27 at 14 38 10

After:
Screen Shot 2022-10-27 at 14 38 20

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner October 27, 2022 16:35
@BrunoQuaresma BrunoQuaresma self-assigned this Oct 27, 2022
@BrunoQuaresma BrunoQuaresma requested review from code-asher and removed request for a team October 27, 2022 16:35
@kylecarbs
Copy link
Member

The button looks a bit misleading there I feel, almost as though I could click it...

@BrunoQuaresma
Copy link
Collaborator Author

BrunoQuaresma commented Oct 27, 2022

@kylecarbs I feel the same about the button but I don't know how to improve that, to be honest. I asked Ted's help but I think this version is better than what we have now.

@bpmct
Copy link
Member

bpmct commented Oct 27, 2022

@kylecarbs I feel the same about the button but I don't know how to improve that, to be honest. I asked Ted's help but I think this version is better than what we have now.

Would a thin outline with no background work?

@BrunoQuaresma
Copy link
Collaborator Author

Would a thin outline with no background work?

Just context, this comment was before the current screenshot where I was using buttons instead of pills - I know the difference is only the amount of border-radius 😆 - I tried without the background and I didn't like it too much, to be honest. It does not give enough contrast to that.

Co-authored-by: Kira Pilot <kira@coder.com>
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small stuff in this review; looks great!

@BrunoQuaresma BrunoQuaresma merged commit ce2a7d4 into main Oct 27, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/update-resource-preview branch October 27, 2022 20:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants