-
Notifications
You must be signed in to change notification settings - Fork 892
refactor: Refactor template resources #4789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The button looks a bit misleading there I feel, almost as though I could click it... |
@kylecarbs I feel the same about the button but I don't know how to improve that, to be honest. I asked Ted's help but I think this version is better than what we have now. |
Would a thin outline with no background work? |
Just context, this comment was before the current screenshot where I was using buttons instead of pills - I know the difference is only the amount of border-radius 😆 - I tried without the background and I didn't like it too much, to be honest. It does not give enough contrast to that. |
Co-authored-by: Kira Pilot <kira@coder.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small stuff in this review; looks great!
Co-authored-by: Kira Pilot <kira@coder.com>
…nto bq/update-resource-preview
Before:

After:
