Skip to content

feat: Add VSCODE_PROXY_URI to surface code-server ports #4798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 4, 2022
Merged

feat: Add VSCODE_PROXY_URI to surface code-server ports #4798

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e35a0dd
feat: Add `VSCODE_PROXY_URI` to surface code-server ports
kylecarbs Oct 28, 2022
9ee60d6
Check if app host is provided
kylecarbs Nov 1, 2022
87b5113
Fix conn cache
kylecarbs Nov 1, 2022
1fca44c
Merge branch 'main' into addproxy
kylecarbs Nov 2, 2022
c9ec3ce
Fix race condition on close
kylecarbs Nov 3, 2022
ee535a0
Merge branch 'main' into addproxy
kylecarbs Nov 3, 2022
8482346
Fix vscode configs test
kylecarbs Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix conn cache
  • Loading branch information
@kylecarbs
kylecarbs committed Nov 1, 2022
commit 87b5113774061981dcbb341a468bdb52a1560693
7 changes: 4 additions & 3 deletions coderd/wsconncache/wsconncache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,12 @@ func (c *Cache) Acquire(r *http.Request, id uuid.UUID) (*Conn, func(), error) {
// A singleflight group is used to allow for concurrent requests to the
// same identifier to resolve.
rawConn, err, _ = c.connGroup.Do(id.String(), func() (interface{}, error) {
c.closeMutex.Lock()
c.closeGroup.Add(1)
c.closeMutex.Unlock()
agentConn, err := c.dialer(r, id)
if err != nil {
c.closeGroup.Done()
return nil, xerrors.Errorf("dial: %w", err)
}
timeoutCtx, timeoutCancelFunc := context.WithCancel(context.Background())
Expand All @@ -102,9 +106,6 @@ func (c *Cache) Acquire(r *http.Request, id uuid.UUID) (*Conn, func(), error) {
timeoutCancel: timeoutCancelFunc,
transport: transport,
}
c.closeMutex.Lock()
c.closeGroup.Add(1)
c.closeMutex.Unlock()
go func() {
defer c.closeGroup.Done()
var err error
Expand Down