Skip to content

refactor: Show template versions as timeline #4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 31, 2022
Merged

refactor: Show template versions as timeline #4800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9271497
Return user on created by
BrunoQuaresma Oct 28, 2022
0f51a23
Extra timeline
BrunoQuaresma Oct 28, 2022
8ff38c8
Fix templates
BrunoQuaresma Oct 28, 2022
0f84455
Fix tests
BrunoQuaresma Oct 28, 2022
ffa188d
Fix types
BrunoQuaresma Oct 28, 2022
ec029e8
Update versions to timeline
BrunoQuaresma Oct 28, 2022
cf599aa
Fix entities
BrunoQuaresma Oct 28, 2022
d80a7d7
Merge branch 'main' of github.com:coder/coder into bq/refactor-versions
BrunoQuaresma Oct 28, 2022
0935969
Fix test
BrunoQuaresma Oct 28, 2022
053dc9b
fix: migration
BrunoQuaresma Oct 28, 2022
5b835ba
Fix migration
BrunoQuaresma Oct 28, 2022
2cc3127
Fix tests and migrations
BrunoQuaresma Oct 28, 2022
15c7d9c
Fix down migration
BrunoQuaresma Oct 28, 2022
acdb081
Use store
BrunoQuaresma Oct 31, 2022
0723e3d
Merge branch 'main' of github.com:coder/coder into bq/refactor-versions
BrunoQuaresma Oct 31, 2022
67e51f0
Remove unecessary eslint comment
BrunoQuaresma Oct 31, 2022
b0729ce
Fix eslint
BrunoQuaresma Oct 31, 2022
cf6484c
Add line
BrunoQuaresma Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Oct 28, 2022
commit 0f8445582ce8483f361979dd22be4cb2f921e5b9
2 changes: 1 addition & 1 deletion cli/templateversions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func displayTemplateVersions(activeVersionID uuid.UUID, templateVersions ...code
rows[i] = templateVersionRow{
Name: templateVersion.Name,
CreatedAt: templateVersion.CreatedAt,
CreatedBy: templateVersion.CreatedByName,
CreatedBy: templateVersion.CreatedBy.Username,
Status: strings.Title(string(templateVersion.Job.Status)),
Active: activeStatus,
}
Expand Down
2 changes: 1 addition & 1 deletion cli/templateversions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func TestTemplateVersions(t *testing.T) {
require.NoError(t, <-errC)

pty.ExpectMatch(version.Name)
pty.ExpectMatch(version.CreatedByName)
pty.ExpectMatch(version.CreatedBy.Username)
pty.ExpectMatch("Active")
})
}