fix: use -no-color when calling terraform show state
#4812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Oct 31, 2022
| @@ -248,9 +251,6 @@ func (r *Runner) doCleanFinish(ctx context.Context) { | |||
| completedJob *proto.CompletedJob | |||
| ) | |||
|
|
|||
| ctx, span := r.startTrace(ctx, tracing.FuncName()) | |||
| defer span.End() | |||
There was a problem hiding this comment.
Not sure why this was removed but seems like it should be fine.
There was a problem hiding this comment.
I was originally going in to change this but then I found the -no-color issue so I bundled them up.
There was a problem hiding this comment.
Having doCleanFinish be a super long span didn't seem that useful since everything else inside of it was already traced.
There was a problem hiding this comment.
I see what you mean. I guess it gives a better idea of how the code is structured, but not a necessity if you feel cleanliness wins here 👍🏻.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.