Skip to content

refactor: Improve agent loading state #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2022
Merged

refactor: Improve agent loading state #4814

merged 2 commits into from
Oct 31, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

  • Fix circular progress style

    • It was causing a weird animation in the AppLink during the loading

  • Improve the loading state for the agent

    • Adding a skeleton for the version and latency
    • Sync status pulse animation with the skeleton animation

    Sorry for not adding screenshots. This one would be a better view in Storybook.

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner October 31, 2022 18:58
@BrunoQuaresma BrunoQuaresma self-assigned this Oct 31, 2022
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team October 31, 2022 18:58
@BrunoQuaresma BrunoQuaresma merged commit 97bcd44 into main Oct 31, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-circular-progress branch October 31, 2022 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @Kira-Pilot