Skip to content

refactor: Refactor build page #4815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2022
Merged

refactor: Refactor build page #4815

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f90d06
refactor: Improve build page
BrunoQuaresma Oct 31, 2022
94424aa
Add build translation
BrunoQuaresma Oct 31, 2022
c78f22c
Add build avatar better props
BrunoQuaresma Oct 31, 2022
bbca39d
Get build number from build
BrunoQuaresma Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Get build number from build
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Nov 1, 2022
commit bbca39d8c42c0fe1f1d817ddb0e514ff02d9099a
12 changes: 1 addition & 11 deletions site/src/pages/WorkspaceBuildPage/WorkspaceBuildPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { BuildAvatar } from "components/BuildsTable/BuildAvatar"
import { FC } from "react"
import { useParams } from "react-router-dom"
import { ProvisionerJobLog, WorkspaceBuild } from "../../api/typesGenerated"
import { Loader } from "../../components/Loader/Loader"
import { Margins } from "../../components/Margins/Margins"
Expand All @@ -21,13 +20,6 @@ const sortLogsByCreatedAt = (logs: ProvisionerJobLog[]) => {
)
}

const useBuildNumber = () => {
const { buildNumber } = useParams()
if (!buildNumber) {
throw new Error("Build number not found")
}
return buildNumber
}
export interface WorkspaceBuildPageViewProps {
logs: ProvisionerJobLog[] | undefined
build: WorkspaceBuild | undefined
Expand All @@ -37,16 +29,14 @@ export const WorkspaceBuildPageView: FC<WorkspaceBuildPageViewProps> = ({
logs,
build,
}) => {
const buildNumber = useBuildNumber()

return (
<Margins>
{build && (
<PageHeader>
<Stack direction="row" alignItems="center" spacing={3}>
<BuildAvatar build={build} size={48} />
<div>
<PageHeaderTitle>Build #{buildNumber}</PageHeaderTitle>
<PageHeaderTitle>Build #{build.build_number}</PageHeaderTitle>
<PageHeaderSubtitle condensed>
{build.initiator_name}
</PageHeaderSubtitle>
Expand Down