Skip to content

feat: add option for exporting traces to a provided Honeycomb team #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 1, 2022
Merged

feat: add option for exporting traces to a provided Honeycomb team #4816

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca5539b
feat: add option for exporting traces to a provided Honeycomb team
coadler Oct 31, 2022
8117a7f
fixup! feat: add option for exporting traces to a provided Honeycomb …
coadler Oct 31, 2022
6c7a368
fixup! feat: add option for exporting traces to a provided Honeycomb …
coadler Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! feat: add option for exporting traces to a provided Honeycomb … 
…team
  • Loading branch information
@coadler
coadler committed Oct 31, 2022
commit 8117a7f49c213f50639ee6d78fbe24f003d6e92a
7 changes: 4 additions & 3 deletions cli/deployment/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,9 +296,10 @@ func newConfig() *codersdk.DeploymentConfig {
Flag: "trace",
},
HoneycombAPIKey: &codersdk.DeploymentConfigField[string]{
Name: "Trace Honeycomb API Key",
Usage: "Enables trace exporting to Honeycomb.io using the provided API Key.",
Flag: "trace-honeycomb-api-key",
Name: "Trace Honeycomb API Key",
Usage: "Enables trace exporting to Honeycomb.io using the provided API Key.",
Flag: "trace-honeycomb-api-key",
Secret: true,
},
},
SecureAuthCookie: &codersdk.DeploymentConfigField[bool]{
Expand Down
8 changes: 7 additions & 1 deletion site/src/api/typesGenerated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ export interface DeploymentConfig {
readonly oidc: OIDCConfig
readonly telemetry: TelemetryConfig
readonly tls: TLSConfig
readonly trace_enable: DeploymentConfigField<boolean>
readonly trace: TraceConfig
readonly secure_auth_cookie: DeploymentConfigField<boolean>
readonly ssh_keygen_algorithm: DeploymentConfigField<string>
readonly auto_import_templates: DeploymentConfigField<string[]>
Expand Down Expand Up @@ -664,6 +664,12 @@ export interface TemplateVersionsByTemplateRequest extends Pagination {
readonly template_id: string
}

// From codersdk/deploymentconfig.go
export interface TraceConfig {
readonly enable: DeploymentConfigField<boolean>
readonly honeycomb_api_key: DeploymentConfigField<string>
}

// From codersdk/templates.go
export interface UpdateActiveTemplateVersion {
readonly id: string
Expand Down