Skip to content

refactor: extend Overrides for MuiSkeleton #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2022
Merged

refactor: extend Overrides for MuiSkeleton #4818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
531aeb7
refactor: extend Overrides for MuiSkeleton
jsjoeio Oct 31, 2022
681e017
formatting
jsjoeio Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions site/src/theme/overrides.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
import { lighten, Theme } from "@material-ui/core/styles"
import { lighten, Theme, StyleRules } from "@material-ui/core/styles"
import { Overrides } from "@material-ui/core/styles/overrides"
import { SkeletonClassKey } from "@material-ui/lab"
import { colors } from "./colors"
import { borderRadius, borderRadiusSm } from "./constants"

export const getOverrides = ({ palette, breakpoints }: Theme): Overrides => {
type ExtendedOverrides = Overrides & {
MuiSkeleton: Partial<StyleRules<SkeletonClassKey>>
}

export const getOverrides = ({
palette,
breakpoints,
}: Theme): ExtendedOverrides => {
return {
MuiCssBaseline: {
"@global": {
Expand Down Expand Up @@ -190,8 +198,6 @@ export const getOverrides = ({ palette, breakpoints }: Theme): Overrides => {
marginTop: 8,
},
},
// eslint-disable-next-line @typescript-eslint/ban-ts-comment -- The Mui types don't accept the MuiSkeleton but it works. I tried to extends the Overrides interface with no success.
// @ts-ignore
MuiSkeleton: {
root: {
backgroundColor: palette.divider,
Expand Down