Skip to content

fix: Use immutable links for docker with intellij/pycharm #4834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Nov 1, 2022

The original links broke and made markdown link checker cry

@mafredri mafredri self-assigned this Nov 1, 2022
@mafredri mafredri requested a review from a team November 1, 2022 12:35
@deansheather deansheather requested review from sharkymark and ammario and removed request for a team November 1, 2022 12:37
@deansheather
Copy link
Member

I assigned Mark and Ammar instead as they'll hopefully know better than anyone else whether the new links are the intended ones or not.

@mafredri
Copy link
Member Author

mafredri commented Nov 1, 2022

I assigned Mark and Ammar instead as they'll hopefully know better than anyone else whether the new links are the intended ones or not.

Thanks. This is blocking PRs currently, which is why I did the catch all review, but this is a fair assumption. (The links point to the same files as before, those files were simply moved.)

@sharkymark
Copy link
Contributor

I removed the Docker projector links a. because the projector installation approach is out-dated and because pycharm and intellij on docker is a poor experience unless you have a lot of compute which most evaluators will not.

From what I see in the commit, the docker links are being added back.

Copy link
Contributor

@sharkymark sharkymark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer these get deleted but if this is blocking something, I approve.

@mafredri
Copy link
Member Author

mafredri commented Nov 1, 2022

@sharkymark Ah, I didn't notice your PR that removes these links: #4819

I just wanted to fix the broken links in main. I'll merge this PR now to fix the immediate issue, but removing them is fine by me. 👍🏻

@mafredri mafredri merged commit 21e6494 into main Nov 1, 2022
@mafredri mafredri deleted the mafredri/fix-markdown-link-checker-error branch November 1, 2022 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants