Audit date filter/kira pilot #4845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
approved these changes
Nov 2, 2022
| @@ -2995,6 +2995,16 @@ func (q *fakeQuerier) GetAuditLogsOffset(ctx context.Context, arg database.GetAu | |||
| continue | |||
| } | |||
| } | |||
| if arg.DateFrom != (time.Time{}) { | |||
There was a problem hiding this comment.
I think all of these could be if !arg.DateFrom.IsZero()
coderd/audit.go
Outdated
Comment on lines
302
to
312
| var ( | ||
| filter = database.GetAuditLogsOffsetParams{ | ||
| ResourceType: resourceTypeFromString(parser.String(searchParams, "", "resource_type")), | ||
| ResourceID: parser.UUID(searchParams, uuid.Nil, "resource_id"), | ||
| Action: actionFromString(parser.String(searchParams, "", "action")), | ||
| Username: parser.String(searchParams, "", "username"), | ||
| Email: parser.String(searchParams, "", "email"), | ||
| DateFrom: parsedDateFrom, | ||
| DateTo: parsedDateTo, | ||
| } | ||
| ) |
There was a problem hiding this comment.
nit: this could probably just use := instead of var ()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4769
Down the road I would like to add UI selects for date, but we need to explore date pickers as a FE team.
If someone could help me out with the test that is failing, I would appreciate it. It seems theThanks Dean!Timeparam I am passing when generating test audit logs isn't actually being saved.