Skip to content

refactor: Refactor create workspace page #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 2, 2022
Merged

refactor: Refactor create workspace page #4862

merged 7 commits into from
Nov 2, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Before:
Screen Shot 2022-11-02 at 14 03 09

Now:
Screen Shot 2022-11-02 at 14 03 43

I had to change some stuff in the design:

  • The form header does not have a bottom line
  • Some font sizes and spaces changed because of MUI floating labels in some inputs. Some inputs don't have descriptions and names making some spacing bad in those situations.

@BrunoQuaresma BrunoQuaresma self-assigned this Nov 2, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner November 2, 2022 17:06
@BrunoQuaresma BrunoQuaresma requested review from presleyp and removed request for a team November 2, 2022 17:06
presleyp
presleyp approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) November 2, 2022 20:03
@BrunoQuaresma BrunoQuaresma merged commit f76e7b1 into main Nov 2, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/create-workspace-form branch November 2, 2022 20:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @presleyp