Skip to content

docs: update port forwarding to state it works without a wildcard with tunnel #4887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 9, 2022
Merged

docs: update port forwarding to state it works without a wildcard with tunnel #4887

merged 7 commits into from
Nov 9, 2022

Conversation

sharkymark
Copy link
Contributor

This PR:

  1. Clarifies the port forwarding dashboard docs to state that port forwarding works without a wildcard domain environment variable when tunnel (reverse proxy) is used.

@sharkymark sharkymark requested review from ammario and bpmct November 3, 2022 23:40
ammario
ammario previously requested changes Nov 3, 2022
View reviewed changes
@ghuntley ghuntley enabled auto-merge (squash) November 9, 2022 08:44
sharkymark and others added 2 commits November 9, 2022 08:46
@ghuntley ghuntley force-pushed the docs-port-forwarding-tunnel branch from ed10f8e to 6818b28 Compare November 9, 2022 08:46
@ghuntley ghuntley merged commit b6f2a29 into main Nov 9, 2022
@ghuntley ghuntley deleted the docs-port-forwarding-tunnel branch November 9, 2022 10:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ghuntley ghuntley ghuntley left review comments

@bpmct bpmct bpmct approved these changes

@ammario ammario ammario left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sharkymark @ghuntley @ammario @bpmct