Skip to content

fix: Disable viper auto-env to avoid assigning to parent structs #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2022
Merged

fix: Disable viper auto-env to avoid assigning to parent structs #4893

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69326d1
fix: Disable viper auto-env to avoid assigning to parent structs
mafredri Nov 4, 2022
2f4ac30
Add test for wrong-env breakage
mafredri Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test for wrong-env breakage
  • Loading branch information
@mafredri
mafredri committed Nov 4, 2022
commit 2f4ac3013ebc62dc123e79bb91afba2fbc498099
10 changes: 10 additions & 0 deletions cli/deployment/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,16 @@ func TestConfig(t *testing.T) {
Regex: "gitlab.com",
}}, config.GitAuth.Value)
},
}, {
Name: "Wrong env must not break default values",
Env: map[string]string{
"CODER_PROMETHEUS_ENABLE": "true",
"CODER_PROMETHEUS": "true", // Wrong env name, must not break prom addr.
},
Valid: func(config *codersdk.DeploymentConfig) {
require.Equal(t, config.Prometheus.Enable.Value, true)
require.Equal(t, config.Prometheus.Address.Value, config.Prometheus.Address.Default)
},
}} {
tc := tc
t.Run(tc.Name, func(t *testing.T) {
Expand Down