Skip to content

fix: Allow overriding env variable names, restore CODER_TELEMETRY #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fix: Allow overriding env variable names, restore CODER_TELEMETRY #4894

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
69326d1
fix: Disable viper auto-env to avoid assigning to parent structs
mafredri Nov 4, 2022
2f4ac30
Add test for wrong-env breakage
mafredri Nov 4, 2022
6408959
fix: Allow overriding env variable names, restore CODER_TELEMETRY
mafredri Nov 4, 2022
6aebb36
Ensure Env field is populated
mafredri Nov 4, 2022
7cb8a98
Add test for env field population
mafredri Nov 4, 2022
96785a7
Comment
mafredri Nov 4, 2022
6aecff8
Restore CODER_TRACE as well
mafredri Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for env field population
  • Loading branch information
@mafredri
mafredri committed Nov 4, 2022
commit 7cb8a98f0dcb1c7547476a19b3f8cc9d738a4d3c
6 changes: 6 additions & 0 deletions cli/deployment/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,12 @@ func TestConfig(t *testing.T) {
require.Equal(t, config.Prometheus.Enable.Value, true)
require.Equal(t, config.Prometheus.Address.Value, config.Prometheus.Address.Default)
},
}, {
Name: "Env fields are populated with manual or automatic name",
Valid: func(config *codersdk.DeploymentConfig) {
require.Equal(t, config.Telemetry.Enable.Env, "CODER_TELEMETRY")
require.Equal(t, config.Prometheus.Address.Env, "CODER_PROMETHEUS_ADDRESS")
},
}} {
tc := tc
t.Run(tc.Name, func(t *testing.T) {
Expand Down