Skip to content

refactor: Improve long rows in audit log #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2022
Merged

refactor: Improve long rows in audit log #4904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0ca2c
refactor: Improve long rows in audit log
BrunoQuaresma Nov 4, 2022
8016819
Remove unecessary css
BrunoQuaresma Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion site/src/components/AuditLogRow/AuditLogDiff.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ const useStyles = makeStyles((theme) => ({
flex: 1,
paddingTop: theme.spacing(2),
paddingBottom: theme.spacing(2.5),
paddingRight: theme.spacing(2),
lineHeight: "160%",
alignSelf: "stretch",
},

diffOld: {
Expand All @@ -101,7 +103,7 @@ const useStyles = makeStyles((theme) => ({

diffLine: {
opacity: 0.5,
width: theme.spacing(8),
width: theme.spacing(6),
textAlign: "right",
flexShrink: 0,
},
Expand All @@ -110,6 +112,7 @@ const useStyles = makeStyles((theme) => ({
width: theme.spacing(4),
textAlign: "center",
fontSize: theme.typography.body1.fontSize,
flexShrink: 0,
},

diffNew: {
Expand Down
21 changes: 20 additions & 1 deletion site/src/components/AuditLogRow/AuditLogRow.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ const Template: Story<AuditLogRowProps> = (args) => (

export const NoDiff = Template.bind({})
NoDiff.args = {
auditLog: MockAuditLog,
auditLog: {
...MockAuditLog,
diff: {},
},
}

export const WithDiff = Template.bind({})
Expand All @@ -43,6 +46,22 @@ WithDiff.args = {
defaultIsDiffOpen: true,
}

export const WithLongDiffRow = Template.bind({})
WithLongDiffRow.args = {
auditLog: {
...MockAuditLog2,
diff: {
...MockAuditLog2.diff,
icon: {
old: "https://www.docker.com/wp-content/uploads/2022/03/Moby-logo.png",
new: "https://www.docker.com/wp-content/uploads/2022/03/vertical-logo-monochromatic.png",
secret: false,
},
},
},
defaultIsDiffOpen: true,
}

export const WithWorkspaceBuild = Template.bind({})
WithWorkspaceBuild.args = {
auditLog: MockAuditLogWithWorkspaceBuild,
Expand Down